[JExtract] Generate JNI code for memory management with SwiftKitCore
#302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsodgaard
changed the title
SwiftKitCoreSwiftKitCore
ktoso
reviewed
Jul 10, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+SwiftThunkPrinting.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Jul 10, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaBindingsPrinting.swift
Show resolved
Hide resolved
ktoso
reviewed
Jul 10, 2025
| @@ -40,8 +41,10 @@ static void examples() { | |||
|
|
|||
| MySwiftClass.method(); | |||
|
|
|||
| MySwiftClass myClass = MySwiftClass.init(10, 5); | |||
| MySwiftClass myClass2 = MySwiftClass.init(); | |||
| try (var arena = new ConfinedSwiftMemorySession(Thread.currentThread())) { | |||
There was a problem hiding this comment.
Nitpick that this may want to be SwiftArena.ofConfined()
There was a problem hiding this comment.
agreed, but the problem is that Java 7 does not support static methods on interfaces.
There was a problem hiding this comment.
Ugh... heh I wonder if we need to really support so long back, we'll see as we chat with android workgroup.
Otherwise the Java pattern is to do a type like SwiftArenas that's a class and put the static methods on that
There was a problem hiding this comment.
At least we can make a () constructor that gets the current thread as well then, we can do this in a follow up
ktoso
reviewed
Jul 10, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaBindingsPrinting.swift
Show resolved
Hide resolved
ktoso
approved these changes
Jul 10, 2025
madsodgaard
changed the title
SwiftKitCoreSwiftKitCore
ktoso
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SwiftKitCore support for the generated code for classes. This means that we will actually destroy the instances once the arena decides to so.